Open
Conversation
lihnick
requested review from
ManoloAlvarezForo,
bkonuwa,
dkordik and
wendigolabs
lihnick
commented
Nov 4, 2021
Comment on lines
+540
to
+559
| <Input | ||
| value={selectedDay.toISOString().split('T')[0]} | ||
| onClick={() => setShowInlineCalendar(true)} | ||
| /> | ||
| {showInlineCalendar && ( | ||
| <Paper | ||
| style={{ | ||
| boxShadow: '0px 0px 2px 2px rgb(0 0 0 / 20%)', | ||
| display: 'table', | ||
| padding: '2px', | ||
| position: 'absolute', | ||
| }} | ||
| > | ||
| <DatePicker | ||
| showOutsideDays | ||
| onDayClick={handleInlineDateClick} | ||
| selectedDays={selectedDay} | ||
| /> | ||
| </Paper> | ||
| )} |
Collaborator
Author
There was a problem hiding this comment.
This is an example of what it might look like to extend the DatePicker component to make it inline.
lihnick
commented
Nov 4, 2021
Comment on lines
+65
to
+73
| if (passedProps.classNames) { | ||
| Object.entries(passedProps.classNames).forEach((classes) => { | ||
| if (classes.length === 2) { | ||
| styleOverride[classes[0]] = `${styleOverride[classes[0]]} ${ | ||
| classes[1] | ||
| }`; | ||
| } | ||
| }); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This pass-through Date-Picker component allows consuming apps to overwrite specific attribute (e.g. footer attribute) of the class object without overriding the entire classNames object.
dkordik
approved these changes
Dec 8, 2021
Collaborator
dkordik
left a comment
dkordik
left a comment
There was a problem hiding this comment.
sorry, didn't realize you were still waiting for approvals on this. lgtm!
ManoloAlvarezForo
approved these changes
Dec 14, 2021
Contributor
ManoloAlvarezForo
left a comment
ManoloAlvarezForo
left a comment
There was a problem hiding this comment.
Sorry for the delay to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.